host-containers: migrate to use config file #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-berning
force-pushed
the
host-containers-config-file
branch
2 times, most recently
from
1076397
to
903c5ea
Compare
|
^ update template to |
webern
approved these changes
Feb 15, 2024
sam-berning
force-pushed
the
host-containers-config-file
branch
from
903c5ea
to
176c883
Compare
|
^ address @webern's comments |
jmt-lab
approved these changes
Feb 16, 2024
webern
approved these changes
Feb 16, 2024
sam-berning
force-pushed
the
host-containers-config-file
branch
2 times, most recently
from
3346ec3
to
9dad1a7
Compare
webern
suggested changes
Mar 5, 2024
There was a problem hiding this comment.
Switching my review status as it needs a rebase and then needs testing. Here is the test plan that we have suggested, this should be pasted into the testing section of the PR description
- [ ] Ran `cargo +nightly udeps` to ensure all unused dependencies have been removed
- [ ] Pass the settings on first boot via userdata. Verify config.
- [ ] cat /etc/os-release record your build ID include commit sha, record this
- [ ] Use apiclient to update relevant settings at runtime. Verify config was updated correctly.
- [ ] Downgrade to older version.
- [ ] verify connectivity
- [ ] cat /etc/os-release to verify lower version
- [ ] verify that migrations have changed the metadata/settings as expected (i.e. they are gone from the datastore, or lists have been changed back)
- [ ] Upgrade to newer version.
- [ ] verify connectivity
- [ ] cat /etc/os-release to verify version
- [ ] verify config file
This removes the dependency on calling the Settings API. It instead depends on a config file (defaults to /etc/host-containers/host-containers.toml) Signed-off-by: Sam Berning <[email protected]>
Signed-off-by: Sam Berning <[email protected]>
Signed-off-by: Sam Berning <[email protected]>
sam-berning
force-pushed
the
host-containers-config-file
branch
from
9dad1a7
to
1e9e8f3
Compare
|
^ testing summary:
|
|
Looks good to me as well |
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #3627
Description of changes:
Removes dependency on the API model from host-containers by changing it to use a config file rendered from the settings.
Testing done:
cargo +nightly udepsto ensure all unused dependencies have been removedTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.